Low Findings
Code Can't be Compiled Correctly
Severity: Low
Ecosystem: Sui
Protocol: Suia
Auditor: MoveBit
Report Date: May 2023
Description:
The suia_capy.move can not be compiled correctly with the local sui and sui-capybaras dependencies.
The unit test is throwing an error when executed
Severity: Low
Ecosystem: Sui
Protocol: MSafe Maven
Auditor: MoveBit
Report Date: May 2023
Description:
The clock::create_for_testing function in SUI has been modified to return a Clock object instead of a shared object. This change has caused the tests to fail when running with the latest version (0.32) of the Sui client.
simple_map::create Is Deprecated
Severity: Low
Ecosystem: Aptos
Protocol: Superposition
Auditor: MoveBit
Report: https://movebit.xyz/reports/Superposition-Final-Audit-Report.pdf
Report Date: Mar 2024
Description:
in many smart contract, simple_map::create is used, but it's a deprecated function, and simple_map::new should be used instead.
The project can not run unit test with latest aptos cli(v1.0.6)
Severity: Low
Ecosystem: Aptos
Protocol: Aries Market(Aptos)
Auditor: MoveBit
Report Date: Feb 2023
Description:
The latest aptos cli(v1.0.6) forces the unit test failure macro # [expected_failure(abort_code = 1)] to have a location parameter. The location parameter is used to specify the location of the failure. It's better to make it compatible and testable with the latest aptos cli for further maintenance.
Some test cases failed
Severity: Low
Ecosystem: Aptos
Protocol: Cetus Concentrated Liquidity Protocol(Aptos)
Auditor: MoveBit
Report Date: Jan 2023
Description:
While running the test cases, some failed in the pool module. For example, the test_swap case failed. In module clmm_math , the test_get_next_price_a_down should be renamed to test_get_next_price_b_down as it tests get_next_sqrt_price_b_down .